Add imageRef to volume controller #633
Conversation
internal/controllers/volume/tests/volume-create-bootable/00-assert.yaml
Outdated
Show resolved
Hide resolved
internal/controllers/volume/tests/volume-dependency/00-create-resources-missing-deps.yaml
Show resolved
Hide resolved
| finalizer, externalObjectFieldOwner, | ||
| ) | ||
|
|
||
| var imageDependency = dependency.NewDeletionGuardDependency[*orcv1alpha1.VolumeList, *orcv1alpha1.Image]( |
There was a problem hiding this comment.
Most likely we don't want it to be a deletion guard because I expect that OpenStack allows us to delete an image after a volume was created from it (to be verified). See how we did for the server's dependency on flavor.
There was a problem hiding this comment.
I will remove it but there is a small danger in that if someone manually deletes the volume after the image is deleted the create image will be called again but would be stuck in a loop of waiting for openstack as the image won't exist (I suspect this is similar to server and flavor)
There was a problem hiding this comment.
I will remove it but there is a small danger in that if someone manually deletes the volume after the image is deleted the create image will be called again but would be stuck in a loop of waiting for openstack as the image won't exist (I suspect this is similar to server and flavor)
Is that true? I've just tried creating a volume from an image, deleting the image, then deleting the volume and it worked fine.
Is that an issue you've seen?
There was a problem hiding this comment.
Deleting the volume on the ORC level would work but if you delete it on the openstack level manually (using openstack command) I suspect it might cause ORC to into a waiting/watching for the image to exist again (trying to reconcile it state by creating it), haven't tried it but I believe this what would happen in this case (which I believe we are ok with on the orc level).
|
/retest |
Enables creating bootable volumes from images by adding an imageRef field to the Volume spec. When specified, the volume is created with the image baked in, making it suitable for boot-from-volume scenarios. Changes: - Add imageRef field to VolumeResourceSpec - Add bootable and imageID fields to VolumeResourceStatus - Add image dependency with deletion guard - Add kuttl tests for bootable volume creation assisted-by: claude
2 participants
Enables creating bootable volumes from images by adding an imageRef
field to the Volume spec. When specified, the volume is created with
the image baked in, making it suitable for boot-from-volume scenarios.
Changes:
assisted-by: claude